createSystemRandom #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 I wrote similar code on several occasions. And yes function in comment is correct |
|
Go ahead and redo it, and I'll apply it. Thanks. |
|
Pull request updated. |
|
Merged. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use case for this is when it's inconvenient to have to restructure your code to live inside
withSystemRandom. I original wrote the attached implementation in my own code and then created this pull request. However, once I looked at the code forwithSystemRandom, it looks like it would be safe to reimplementcreateSystemRandomas:If my understanding is correct, I can update this pull request to use that implementation instead.